Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image to work with Odoo 10.0 #1

Closed
yajo opened this issue Jan 5, 2017 · 3 comments
Closed

Update image to work with Odoo 10.0 #1

yajo opened this issue Jan 5, 2017 · 3 comments
Assignees

Comments

@yajo
Copy link
Contributor

yajo commented Jan 5, 2017

Hi there @lasley, we finally have a working 9.0 version, I hope you like it.

Will you like to fix this one? 😉

@lasley
Copy link
Contributor

lasley commented Jan 5, 2017

Yup I'll take a look today! Lol I love your docs 😛

PS I see you're not testing your Dockers. Check this out: LasLabs/docker-quality-tools#1

@lasley
Copy link
Contributor

lasley commented Jan 5, 2017

Question - why maintain multiple branches? I think a build arg might be the better approach, similar to what I did. In mine it was really just a matter of symlinking openerp-server onto odoo if not in v10.

For the most part the dependencies are the same. Maybe for the differences, we could maintain some sort of apk_requirements_9.txt or something?

Maybe I'm missing something though?

@yajo
Copy link
Contributor Author

yajo commented Jan 9, 2017

PS I see you're not testing your Dockers

I still have not been able to dive into the CI world, I'd thank some help if you want.

Did you know the Docker Hub has {pre,post}_test hooks? (check link below)

Question - why maintain multiple branches? I think a build arg might be the better approach, similar to what I did

Adding build args is a bit cumbersome with current Docker Hub, although perfectly possible with hooks. Check out docker/hub-feedback#508 (comment) and a PoC I have in https://github.com/Tecnativa/docker-ocb/tree/9.0/hooks.

Not sure why, I think I wanted to KISS and get a working 9.0 implementation ASAP, but it seems a very good approach. Possibly we could change this section for a script that detects the version build arg and does what it needs to do.

One cool thing is that if we put those ARG and RUN at the end, then we could leverage builder's cache and build the 10.0 version using the same base layers as the 9.0 one, so we could have successive versions installed faster.

Please notice that I still have to review the image with @pedrobaeza and some things might change (I'll tell you in any case), and also I'm creating a scaffolding branch to get a working environment as quickly as possible.

@yajo yajo self-assigned this Jan 16, 2017
@yajo yajo closed this as completed in 5c26daf Jan 17, 2017
ap-wtioit added a commit to ap-wtioit/docker-odoo-base that referenced this issue Feb 20, 2020
Master merge

Closes Tecnativa#1

See merge request odoo_tools/docker-odoo-base!50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants