-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update image to work with Odoo 10.0 #1
Comments
Yup I'll take a look today! Lol I love your docs 😛 PS I see you're not testing your Dockers. Check this out: LasLabs/docker-quality-tools#1 |
Question - why maintain multiple branches? I think a build arg might be the better approach, similar to what I did. In mine it was really just a matter of symlinking For the most part the dependencies are the same. Maybe for the differences, we could maintain some sort of Maybe I'm missing something though? |
I still have not been able to dive into the CI world, I'd thank some help if you want. Did you know the Docker Hub has
Adding build args is a bit cumbersome with current Docker Hub, although perfectly possible with hooks. Check out docker/hub-feedback#508 (comment) and a PoC I have in https://github.com/Tecnativa/docker-ocb/tree/9.0/hooks. Not sure why, I think I wanted to KISS and get a working 9.0 implementation ASAP, but it seems a very good approach. Possibly we could change this section for a script that detects the version build arg and does what it needs to do. One cool thing is that if we put those Please notice that I still have to review the image with @pedrobaeza and some things might change (I'll tell you in any case), and also I'm creating a scaffolding branch to get a working environment as quickly as possible. |
Master merge Closes Tecnativa#1 See merge request odoo_tools/docker-odoo-base!50
Hi there @lasley, we finally have a working 9.0 version, I hope you like it.
Will you like to fix this one? 😉
The text was updated successfully, but these errors were encountered: