Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmail issue #140

Closed
metalgigio opened this issue Nov 15, 2017 · 15 comments
Closed

gmail issue #140

metalgigio opened this issue Nov 15, 2017 · 15 comments
Labels
bug something in the original template doesn't display correctly Help Wanted! looking for someone to pair with or solve

Comments

@metalgigio
Copy link

Hi,
as you can see the cerberus-hybrid.html does not display properly on gmail on android.

screenshot_20171115-121149

@TedGoas TedGoas added the Help Wanted! looking for someone to pair with or solve label Nov 15, 2017
@metalgigio
Copy link
Author

It's a strange bug. If i remove Email Header table o Hero Image row it display correctly, but not if i have both...

@metalgigio
Copy link
Author

after some test i found that the problem is here:

        /* What it does: Forces Gmail app to display email full width */
        u ~ div .email-container {
	        min-width: 100vw;
        }

just remove that to make it display correct.
Does remove it affects visualizzation on other clients?

@n00bium
Copy link

n00bium commented Nov 16, 2017

Hey there,
i am having the same Problem but I could not reproduce @metalgigio´s suggestion. It is also worth mentionign that the hybrid-template is also broken on Gmail-Webview .
gmail-web

@n00bium
Copy link

n00bium commented Nov 16, 2017

 /* What it does: Forces Gmail app to display email full width */
        u ~ div .email-container {
	        min-width: 100vw;
        }

Removing this does the Trick on Mobile and Web! Great find @metalgigio !

@TedGoas
Copy link
Collaborator

TedGoas commented Nov 16, 2017

@metalgigio @n00bium I'm having trouble reproducing your issue. This is what I see in Litmus:

screen shot 2017-11-16 at 9 57 30 am


screen shot 2017-11-16 at 9 57 37 am

@metalgigio
Copy link
Author

I tested on a nexus 5 and a galaxy s7, both with last version of gmail app. Maybe on litmus they don't have last version of gmail...

@n00bium
Copy link

n00bium commented Nov 16, 2017

I tested on a Oneplus One and on Firefox 56 running on Windows 10. So there is probably something fishy over at litmus´.

@TedGoas
Copy link
Collaborator

TedGoas commented Nov 16, 2017

@metalgigio @n00bium FYI removing this will break Gmail on iOS.

/* What it does: Forces Gmail app to display email full width */
    u ~ div .email-container {
        min-width: 100vw;
    }

This code is supposed to target only one OS. Looking into updating it so it doesn't bleed into where it shouldn't.

@TedGoas TedGoas added the bug something in the original template doesn't display correctly label Nov 16, 2017
@metalgigio
Copy link
Author

@TedGoas what do you mean for break? i do not have ios device to test it

@TedGoas
Copy link
Collaborator

TedGoas commented Nov 16, 2017

@metalgigio
Copy link
Author

Thanks. i think that until we will find a solution i will remove that lines of code, it's seem that bugs on android is worst than on ios (on android it's let u scroll on right like it was bigger that container)

@TedGoas
Copy link
Collaborator

TedGoas commented Nov 16, 2017

Sounds good. I'll leave this open and work on this so hopefully we can get both Gmail's acting consistently.

@TedGoas
Copy link
Collaborator

TedGoas commented Nov 16, 2017

Note to self

@ghost
Copy link

ghost commented Nov 24, 2017

Just to add to this that I had the same issue, removing those lines has fixed it for me on Gmail desktop (viewing on Chrome Linux) and mobile (Huawei P9 Gmail App).

SilverHazeLazers added a commit to SilverHazeLazers/Cerberus that referenced this issue Dec 22, 2017
@SilverHazeLazers
Copy link
Contributor

SilverHazeLazers commented Dec 22, 2017

I have taken a shot at resolving this issue using the link Ted provided. Pull request here #146

Tested as working on latest version of gmail app.

TedGoas added a commit that referenced this issue Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something in the original template doesn't display correctly Help Wanted! looking for someone to pair with or solve
Projects
None yet
Development

No branches or pull requests

4 participants