Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIE sometimes doesn't update diagnostics on change #35

Open
pikajude opened this issue Dec 3, 2018 · 1 comment
Open

HIE sometimes doesn't update diagnostics on change #35

pikajude opened this issue Dec 3, 2018 · 1 comment
Labels
Responsibility: atom-ide-ui Things that should be taken care of by the LSP client (atom-ide-ui) Responsibility: hie Things that should be taken care of by the LSP server (haskell-ide-engine)

Comments

@pikajude
Copy link

pikajude commented Dec 3, 2018

I'm not sure if this is a problem with the atom plugin or with HIE itself. It's also not very reliable to repro so I'll try to give as specific info as I can.

Here's my most reliable repro:

formatUserMessage (u, dm) =
  blue "<<<" -- delete this line and save the file
    <+> dullyellow (brackets ("user" <+> docUnique u))
    <+> string (show dm)
    <>  hardline

This should introduce a parse error, but diagnostics aren't updated until I start typing (anything) in place of the deleted line.

HIE seems to always update diagnostics correctly when I add lines. When I change lines (add or remove characters to introduce nonexistent identifiers) it usually doesn't pick that up either.

@pikajude pikajude changed the title HIE sometimes doesn't update diagnostics on save HIE sometimes doesn't update diagnostics on change Dec 3, 2018
@Tehnix Tehnix self-assigned this Mar 18, 2019
@Tehnix Tehnix added the Responsibility: hie Things that should be taken care of by the LSP server (haskell-ide-engine) label Mar 18, 2019
@Tehnix Tehnix removed their assignment Mar 18, 2019
@Tehnix
Copy link
Owner

Tehnix commented Mar 18, 2019

There's a similar issue tracked in the VS Code extension here haskell/vscode-haskell#143. I suspect that this is an issue with either HIE or with the LSP UIs not correctly updating the outputs.

In either case, I'll await doing anything until the VS Code issue is resolved, since that will probably indicate more or less the same fix that will be required here :)

@Tehnix Tehnix added the Responsibility: atom-ide-ui Things that should be taken care of by the LSP client (atom-ide-ui) label Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Responsibility: atom-ide-ui Things that should be taken care of by the LSP client (atom-ide-ui) Responsibility: hie Things that should be taken care of by the LSP server (haskell-ide-engine)
Projects
None yet
Development

No branches or pull requests

2 participants