Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS-9962 - Fix textColor token in misticaLinkInverse button style #352

Merged

Conversation

franciscojrp
Copy link
Member

@franciscojrp franciscojrp commented Apr 3, 2024

🎟️ Jira ticket

IOS-9962 Wrong colors in misticaLinkInverse button style

πŸ₯… What's the goal?

Fix the button style 'misticaLinkInverse' text color.
It was detected in Wallet that we are using 'textButtonSecondaryInverse' instead of 'textLinkInverse' as defined in here

🚧 How do we do it?

Change 'textColor' to 'textLinkInverse'

πŸ§ͺ How can I verify this?

image

πŸ‘ AppCenter build

image

@franciscojrp franciscojrp marked this pull request as ready for review April 3, 2024 11:38
@franciscojrp franciscojrp requested review from a team, DavidMarinCalleja, Gomay88 and yceballost and removed request for a team April 3, 2024 11:38
@franciscojrp franciscojrp merged commit a84a380 into main Apr 4, 2024
3 checks passed
@franciscojrp franciscojrp deleted the IOS-9962-fix-misticaLinkInverse-style-text-color branch April 4, 2024 07:08
tuentisre pushed a commit that referenced this pull request Apr 4, 2024
## [29.7.2](v29.7.1...v29.7.2) (2024-04-04)

### Bug Fixes

* **Button:** wrong text color token in misticaLinkInverse button style ([#352](#352)) ([a84a380](a84a380))
@tuentisre
Copy link
Collaborator

πŸŽ‰ This PR is included in version 29.7.2 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants