fix(SheetRoot): Reduce transition duration to 0ms in test envs #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcosld
changed the title
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
pladaria
approved these changes
Jul 29, 2024
atabel
reviewed
Jul 29, 2024
| export const transitionDuration = process.env.NODE_ENV === 'test' ? 0 : 400; | ||
| export const transitionDuration = 400; |
There was a problem hiding this comment.
the problem with this change is now you have a time discrepancy between css and js. This transitionDuration is used in this file too. Can't this cause issues too?
There was a problem hiding this comment.
At first glance it should not cause any problems in unit test environment
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 733a0f5. |
atabel
approved these changes
Jul 29, 2024
marcoskolodny
approved these changes
Jul 29, 2024
tuentisre
pushed a commit
that referenced
this pull request
Jul 29, 2024
## [15.16.3](v15.16.2...v15.16.3) (2024-07-29) ### Bug Fixes * **SheetRoot:** Reduce transition duration to 0ms in test envs ([#1186](#1186)) ([8d1dec3](8d1dec3))
|
🎉 This PR is included in version 15.16.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.