Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): different sticky item position crash #3930

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

siguangli
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@siguangli siguangli requested a review from iPel as a code owner June 26, 2024 06:54
@github-actions github-actions bot added renderer: native size: s Denotes a PR that changes 10-99 lines labels Jun 26, 2024
@tencent-adm
Copy link
Member

tencent-adm commented Jun 26, 2024

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ siguangli2018
❌ open-hippy
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

hippy-service bot commented Jun 26, 2024

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

Copy link

hippy-service bot commented Jun 26, 2024

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Jun 26, 2024
@hippy-actions hippy-actions bot enabled auto-merge (rebase) June 26, 2024 07:37
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Jun 26, 2024
@siguangli siguangli added action(squash-merge) Squash and merge action labels Jun 26, 2024
Copy link

hippy-actions bot commented Jun 26, 2024

⚠️ squash-merge action execution failed, because of cannot squash and merge your own pull request.

Please check the following details:

(empty response)

@siguangli

@hippy-actions hippy-actions bot added action(squash-merge): failed Squash and merge action execution failed and removed action(squash-merge) Squash and merge action labels Jun 26, 2024
Copy link

hippy-actions bot commented Jun 26, 2024

⚠️ squash-merge action execution failed, because of cannot squash and merge your own pull request.

Please check the following details:

(empty response)

@siguangli

@siguangli siguangli disabled auto-merge June 26, 2024 08:37
@siguangli siguangli removed action(squash-merge): failed Squash and merge action execution failed labels Jun 26, 2024
@siguangli siguangli merged commit 7f5767a into Tencent:main Jun 26, 2024
45 of 47 checks passed
@siguangli siguangli deleted the fix/Sticky branch June 26, 2024 08:42
siguangli added a commit to siguangli/Hippy that referenced this pull request Jun 26, 2024
Co-authored-by: maxli <maxli@tencent.com>
Co-authored-by: OpenHippy <124017524+open-hippy@users.noreply.github.com>
siguangli added a commit that referenced this pull request Nov 4, 2024
Co-authored-by: maxli <maxli@tencent.com>
Co-authored-by: OpenHippy <124017524+open-hippy@users.noreply.github.com>
siguangli added a commit to siguangli/Hippy that referenced this pull request Nov 28, 2024
Co-authored-by: maxli <maxli@tencent.com>
Co-authored-by: OpenHippy <124017524+open-hippy@users.noreply.github.com>
siguangli added a commit to siguangli/Hippy that referenced this pull request Nov 29, 2024
Co-authored-by: maxli <maxli@tencent.com>
Co-authored-by: OpenHippy <124017524+open-hippy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
renderer: native size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants