Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): static destruct crash in main thread for ios #4085

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix(core): static destruct crash in main thread for ios #4085

merged 1 commit into from
Oct 22, 2024

Conversation

etkmao
Copy link
Collaborator

@etkmao etkmao commented Oct 22, 2024

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@etkmao etkmao requested a review from ilikethese as a code owner October 22, 2024 11:02
@etkmao etkmao requested a review from wwwcg October 22, 2024 11:02
@github-actions github-actions bot added driver: js dom: tree size: xs Denotes a PR that changes 0-9 lines labels Oct 22, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Oct 22, 2024

Hi, @etkmao. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

wwwcg
wwwcg approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@wwwcg wwwcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wwwcg wwwcg merged commit 5418b66 into Tencent:main Oct 22, 2024
37 of 38 checks passed
wwwcg pushed a commit to wwwcg/Hippy that referenced this pull request Oct 23, 2024
@etkmao @wwwcg
fix(core): static destruct crash in main thread for ios (Tencent#4085)
01c7627 
When app exits, child thread may access the destructed global static object, which causing a crash
wwwcg pushed a commit to wwwcg/Hippy that referenced this pull request Oct 23, 2024
@etkmao @wwwcg
fix(core): static destruct crash in main thread for ios (Tencent#4085)
2ffb810 
When app exits, child thread may access the destructed global static object, which causing a crash
wwwcg pushed a commit that referenced this pull request Oct 24, 2024
@etkmao @wwwcg
fix(core): static destruct crash in main thread for ios (#4085)
fcaa1cb 
When app exits, child thread may access the destructed global static object, which causing a crash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwwcg wwwcg wwwcg approved these changes

@ilikethese ilikethese Awaiting requested review from ilikethese ilikethese is a code owner

Assignees
No one assigned
Labels
dom: tree driver: js size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etkmao @wwwcg