Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): check send reach end event #4100

Merged
merged 4 commits into from
Oct 30, 2024
Merged

fix(android): check send reach end event #4100

merged 4 commits into from
Oct 30, 2024

Conversation

siguangli
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@tencent-adm
Copy link
Member

tencent-adm commented Oct 30, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ siguangli
❌ siguangli2018
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the size: s Denotes a PR that changes 10-99 lines label Oct 30, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Oct 30, 2024

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

rockyIsRK
rockyIsRK previously approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@rockyIsRK rockyIsRK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

...ive/android/src/main/java/com/tencent/mtt/hippy/views/hippylist/RecyclerViewEventHelper.java
HippyRecyclerListAdapter listAdapter = ((HippyRecyclerListAdapter) adapter);
int count = listAdapter.getItemCount();
if (listAdapter.hasPullHeader()) {
first = Math.max(0, (first - 1));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里计算是否可加点注释

@siguangli siguangli changed the title Fix/check send reach end event fix(android): check send reach end event Oct 30, 2024
@siguangli siguangli force-pushed the fix/checkSendReachEndEvent branch from 0c6e7af to 2b4c2a4 Compare October 30, 2024 10:05
@siguangli siguangli merged commit 84a02fa into Tencent:main Oct 30, 2024
18 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPel iPel iPel approved these changes

@rockyIsRK rockyIsRK rockyIsRK left review comments

@zealotchen0 zealotchen0 Awaiting requested review from zealotchen0 zealotchen0 is a code owner

Assignees
No one assigned
Labels
driver: js renderer: native size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@siguangli @tencent-adm @iPel @rockyIsRK @siguangli2018