Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add license headers to source files #98

Closed
pah opened this issue Aug 10, 2014 · 3 comments
Closed

Please add license headers to source files #98

pah opened this issue Aug 10, 2014 · 3 comments
Assignees
Labels
Milestone

Comments

@pah
Copy link
Contributor

pah commented Aug 10, 2014

In order to safely track the copyright origins of the source files, e.g. for inclusion in third-party libraries, the source files should carry individual license headers. Something like:

// This file is part of RapidJSON, a fast JSON parser/generator.
// http://miloyip.github.io/rapidjson
// 
// Copyright (C) 2011-2014 Milo Yip and all Contributors
// 
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
// 
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
// 
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.

Especially the optimized algorithms for itoa (#80) and dtoa (#97), which are based on third-party implementations, should mention their origins (and licenses, if different) correctly to avoid licensing issues.

@miloyip
Copy link
Collaborator

miloyip commented Aug 10, 2014

Agreed. I will do it.
Besides, I was thinking whether we should change tabs to space. But will this affect merging in different forks?

@miloyip miloyip added this to the v1.0 Beta milestone Aug 10, 2014
@miloyip miloyip self-assigned this Aug 10, 2014
@pah
Copy link
Contributor Author

pah commented Aug 10, 2014

I would certainly favour moving from tabs to spaces.

To simplify the merging, forks and open pull-requests should then perform the space changes locally as well. On the other hand, there is a "merge strategy" in git to allow ignoring such space changes.

@miloyip
Copy link
Collaborator

miloyip commented Aug 11, 2014

Done both in 0dbcc1c

@miloyip miloyip closed this as completed Aug 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants