Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix rule lost rule id when there is multiple rule in one http or https listener; issue #694 #695

Merged
merged 7 commits into from
Dec 11, 2020
Merged

fix: fix rule lost rule id when there is multiple rule in one http or https listener; issue #694 #695

merged 7 commits into from
Dec 11, 2020

Conversation

abstractmj
Copy link
Collaborator

No description provided.

@abstractmj abstractmj closed this Dec 9, 2020
@abstractmj abstractmj reopened this Dec 9, 2020
@abstractmj abstractmj closed this Dec 10, 2020
@abstractmj abstractmj reopened this Dec 10, 2020
@abstractmj abstractmj closed this Dec 10, 2020
@abstractmj abstractmj reopened this Dec 10, 2020
@abstractmj abstractmj closed this Dec 10, 2020
@abstractmj abstractmj reopened this Dec 10, 2020
@abstractmj abstractmj closed this Dec 11, 2020
@abstractmj abstractmj reopened this Dec 11, 2020
@DeveloperJim DeveloperJim self-assigned this Dec 11, 2020
@DeveloperJim DeveloperJim added confirmed issue is confirmed inner issue comes from Tencent side k8s labels Dec 11, 2020
@abstractmj abstractmj closed this Dec 11, 2020
@abstractmj abstractmj reopened this Dec 11, 2020
DeveloperJim
DeveloperJim approved these changes Dec 11, 2020
View reviewed changes
Copy link
Collaborator

@DeveloperJim DeveloperJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DeveloperJim DeveloperJim merged commit 22a0902 into TencentBlueKing:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeveloperJim DeveloperJim DeveloperJim approved these changes

Assignees

@DeveloperJim DeveloperJim

Labels
confirmed issue is confirmed inner issue comes from Tencent side
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abstractmj @DeveloperJim