New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommitLog / Memtable flush: do not delete commit logs with unused entries #104

Closed

Terkwood opened this issue Aug 10, 2021 · 0 comments · Fixed by #108

Labels

bug

Owner

Terkwood commented Aug 10, 2021 •

edited

Loading

In the case where we are replaying commit logs with a lot of entries, we don't want to delete the commit log in Memtable.flush ~line 41

We should use a second file for the replay mode, one that isn't deleted while being read.

tasks

double check that this is happening, read line probably locks the file so it can't be deleted
if that's the case, clean up the code so it's more clear what's going on

Terkwood added the bug label

This was referenced Aug 11, 2021

Commit Log clean up #107

Closed

feat: commit log swapping #108

Merged

Terkwood closed this as completed in #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment