Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Extension Method GetFrameworkName is misleading #35

Open
CharliePoole opened this issue Sep 3, 2024 · 0 comments
Open

Public Extension Method GetFrameworkName is misleading #35

CharliePoole opened this issue Sep 3, 2024 · 0 comments
Assignees
Labels
Bug Something isn't working
Milestone

Comments

@CharliePoole
Copy link
Contributor

I fixed a bug in TestCentric.Extensibility due to incorrect use of the extension method GetFrameworkName in CecilExtensions.cs. That method merely returns the value of the assembly's TargetFrameworkAttribtue, which is not always present.

However, it was being used on the assumption that it always returned the TargetFramework for which the assembly had been built. Determining that would require some additional steps and involves a few assumptions, making it an unsuitable library API.

After thinking it over, I believe this API should be removed. The assumptions and necessary steps can be incorporated in the individual applications that use TestCentric.Metadata. In fact, that's how I resolved the bug in TestCentric.Extensibility.

@CharliePoole CharliePoole added the Bug Something isn't working label Sep 3, 2024
@CharliePoole CharliePoole self-assigned this Sep 3, 2024
@CharliePoole CharliePoole added this to the 3.1.0 milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant