Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change External Login and Session Cookie name #50

Open
xsoheilalizadeh opened this issue Jan 16, 2019 · 4 comments
Open

Change External Login and Session Cookie name #50

xsoheilalizadeh opened this issue Jan 16, 2019 · 4 comments
Labels
Effort: Low Priority: Medium Product: Web App Type: enhancement New feature or request
Milestone
Backlog

Comments

@xsoheilalizadeh
Copy link
Contributor

Description

We had this issue in #7, but it still is there. In this case, we have to change external login and session cookie name that shows our stack.
2019-01-16_13-08-47

Expected behavior:
Cookies' name mustn't show our stack.

Actual behavior:

Cookies' name shows our stack.

Versions

Browser: Chrome 71
OS: Windows 10
Platform: web
@Hameds Hameds added this to the Backlog milestone Jan 16, 2019
@Hameds
Copy link
Member

Hameds commented Jan 16, 2019

That's a good point. We will fix this. Thanks for the report

@Hameds Hameds modified the milestones: Backlog, v2.10.0 Jan 19, 2019
@Hameds
Copy link
Member

Hameds commented Feb 6, 2019

capture

We can change names but apparently, this is deeper than we thought and social login libs have some hardcoded cookie names too like .AspNet.Correlation.GitHub and we couldn't find any option to rename that cookies so we need more time for proper solution for this, so we put this in backlog temporarily.

@Hameds Hameds modified the milestones: v2.10.0, Backlog Feb 6, 2019
@xsoheilalizadeh
Copy link
Contributor Author

xsoheilalizadeh commented Feb 6, 2019 •
edited
Loading

If you need help to resolve this issue I can do that.

@Hameds
Copy link
Member

Hameds commented Feb 6, 2019

@devSoheilAlizadeh Thanks. We use Owin.Security.Providers.GitHub for Github login integration.
If you know any way to customize cookie name in this lib please let us know, we appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Effort: Low Priority: Medium Product: Web App Type: enhancement New feature or request
Milestone
Backlog
Development

No branches or pull requests
2 participants
@Hameds @xsoheilalizadeh