Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Extend cell background color across entire row #383

Closed
sanga opened this issue Oct 14, 2020 · 4 comments
Closed

[REQUEST] Extend cell background color across entire row #383

sanga opened this issue Oct 14, 2020 · 4 comments
Labels
accepted Task was accepted

Comments

@sanga
Copy link

sanga commented Oct 14, 2020

See: #363 for details but essentially it's so that the following code:

bg = Style(bgcolor="rgb(40,40,40)")
table = Table(box=box.SIMPLE_HEAD, row_styles=["none", bg])

Would produce a table like the following but without the gaps inbetween the grey cells.

image

@willmcgugan
Copy link
Collaborator

I'm thinking that the background color should only extend between cells if the box style has no vertical separator.

For example, this doesn't look right to me:

Screen Shot 2020-10-15 at 10 21 33

But this looks fine:

Screen Shot 2020-10-15 at 10 23 51

What do you think?

@sanga
Copy link
Author

sanga commented Oct 16, 2020

Sure that sounds reasonable to me. I agreed that the first screencap there looks a bit odd.

@willmcgugan willmcgugan added accepted Task was accepted and removed Needs triage labels Oct 16, 2020
@willmcgugan
Copy link
Collaborator

Please try v9.0.0

@sanga
Copy link
Author

sanga commented Oct 18, 2020

Looks primo. Thanks!

@sanga sanga closed this as completed Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Task was accepted
Projects
None yet
Development

No branches or pull requests

2 participants