README review #42
Replies: 3 comments 5 replies
-
Here I was unsure exactly how the change to the background should work. Is there a convention where you set it to a string formatted in a certain way? Or is this string referring to a method that gets called by eval or in some other method? I would suggest to add a line to clarify whether there's some convention/assumption made here :) |
Beta Was this translation helpful? Give feedback.
-
Sorry about the fact that I submitted a PR before seeing that Giorgio was already discussing about the README. Should I do something about the PR (like deleting it if that's an option) or is it fine if I leave it alone? |
Beta Was this translation helpful? Give feedback.
-
@qJakc Curses is an old library for building TUIs. I might link to the Wikipedia page there. The background string is a Rich style. I should link to the Rich docs there so the reader has context. Not sure about a sample log file yet. The format is subject to change and it will quickly get out of date. Good point about the units for timers. Re animate a value, that's not very well worded. It basically means change one value to another value in small increments over time. Some good points there! Feel free to PR those changes. BTW images aren't great for discussions. If you stick to markdown it makes it easier to quote your comments |
Beta Was this translation helpful? Give feedback.
-
Hi Will and Textual community.
This is Giorgio and I have been reviewing the README file :) I'll post here my comments, with screenshot if you find it helpful.
Here maybe the problem is that my English is not good enough, but I didn't get the meaning of this sentence. Maybe changing "that" to "than" works, but I still would not get it :S
Just a small detail anyway. I'll post more here if I find something :)
Beta Was this translation helpful? Give feedback.
All reactions