Change command palette key

[willmcgugan]

ctrl+\ is awkward on some keyboards. Maybe it should just be ctrl+p?

[phershbe]

I found this on a website that aggregates issues tagged as good first issue and would like to work on it if you are open to a new contributor and sure that you want to make the change.

Am I correct in assuming that it is basically as simple as changing the binding in app.py and then updating the corresponding documentation and tests?

[TomJGooding]

I assumed that Ctrl+\ was chosen because this is unlikely to clash with other bindings?

If the command palette binding is going to change to something like Ctrl+p, I'd suggest adding something to the FAQ as I suspect this will create some issues!

[willmcgugan]

Am I correct in assuming that it is basically as simple as changing the binding in app.py and then updating the corresponding documentation and tests?

It is likely as simple as that, yes!

[willmcgugan]

I assumed that Ctrl+\ was chosen because this is unlikely to clash with other bindings?

If the command palette binding is going to change to something like Ctrl+p, I'd suggest adding something to the FAQ as I suspect this will create some issues!

Pretty much, but on some keyboards that combo is tricky. ctrl+p has a higher likelyhood of clashing, but it is often used for a command palette, and muscle memory is hard to change.

A FAQ entry may be a good idea. As would a note how to change it in the docs.

[TomJGooding]

It looks like the command palette binding was changed in #4867.

This change and the new COMMAND_PALETTE_BINDING variable probably needs adding to the CHANGELOG?

[github-actions]

Don't forget to star the repository!

Follow @textualizeio for Textual updates.