How can I know ASVideoNode occurred an error?

[bawn]

Texture version : 2.3.1

For example load .flv video or load timeout. So far I have not found any error callback.

[SergeyPetrachkov]

Hi @bawn ! I've added to ASVideoNode.h the following:

- (void)videoNodeDidFailToInitAsset:(ASVideoNode *)videoNode withError:(NSError *)error;

and then in ASVideoNode.mm inside
- (void)prepareToPlayAsset:(AVAsset *)asset withKeys:(NSArray<NSString *> *)requestedKeys

i add

[self.delegate videoNodeDidFailToInitAsset:self withError:error];

like this :

ASDisplayNodeAssertMainThread();
 
 for (NSString *key in requestedKeys) {
   NSError *error = nil;
   AVKeyValueStatus keyStatus = [asset statusOfValueForKey:key error:&error];
   if (keyStatus == AVKeyValueStatusFailed) {
       NSLog(@"Asset loading failed with error: %@", error);
       [self.delegate videoNodeDidFailToInitAsset:self withError:error];

   }
 }
 
 if ([asset isPlayable] == NO) {
   NSLog(@"Asset is not playable.");
   return;
 }

then you can detect errors. I've never submitted that Improvement proposal to the Texture team but i think you might find it helpful.

[SergeyPetrachkov]

and don't forget to add these files to your git and update CI build host to work around all your pod updates in case you use it.

[bawn]

@petrachkov Thanks, This is really useful. I think you can try submit a RP.

[SergeyPetrachkov]

Just have done that. Waiting for approval :)