diff --git a/Texture.podspec b/Texture.podspec
index 66a814c82..fa34201db 100644
--- a/Texture.podspec
+++ b/Texture.podspec
@@ -20,7 +20,7 @@ Pod::Spec.new do |spec|
# These will be lowered into subspecs in the future. Only here for ASVideoNode.
core.frameworks = ['AVFoundation', 'CoreMedia']
- core.compiler_flags = '-fno-exceptions'
+ core.compiler_flags = '-fno-exceptions -Wno-implicit-retain-self'
core.public_header_files = [
'Source/*.h',
'Source/Details/**/*.h',
diff --git a/examples/ASDKgram/Sample.xcodeproj/project.pbxproj b/examples/ASDKgram/Sample.xcodeproj/project.pbxproj
index 08713d5b1..97ef0f3c5 100644
--- a/examples/ASDKgram/Sample.xcodeproj/project.pbxproj
+++ b/examples/ASDKgram/Sample.xcodeproj/project.pbxproj
@@ -401,6 +401,7 @@
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
+ CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -443,6 +444,7 @@
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
+ CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -470,6 +472,7 @@
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
+ CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = NO;
CODE_SIGN_IDENTITY = "iPhone Developer";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
GCC_PRECOMPILE_PREFIX_HEADER = YES;
@@ -489,6 +492,7 @@
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
+ CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = NO;
CODE_SIGN_IDENTITY = "iPhone Developer";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
GCC_PRECOMPILE_PREFIX_HEADER = YES;
diff --git a/examples/ASDKgram/Sample/AppDelegate.m b/examples/ASDKgram/Sample/AppDelegate.m
index 019c6a71b..9058c8f10 100644
--- a/examples/ASDKgram/Sample/AppDelegate.m
+++ b/examples/ASDKgram/Sample/AppDelegate.m
@@ -39,18 +39,23 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
// ASDK Home Feed viewController & navController
PhotoFeedNodeController *asdkHomeFeedVC = [[PhotoFeedNodeController alloc] init];
UINavigationController *asdkHomeFeedNavCtrl = [[UINavigationController alloc] initWithRootViewController:asdkHomeFeedVC];
+ asdkHomeFeedNavCtrl.navigationBar.barStyle = UIBarStyleBlack;
asdkHomeFeedNavCtrl.tabBarItem = [[UITabBarItem alloc] initWithTitle:@"ASDK" image:[UIImage imageNamed:@"home"] tag:0];
asdkHomeFeedNavCtrl.hidesBarsOnSwipe = YES;
// ListKit Home Feed viewController & navController
PhotoFeedListKitViewController *listKitHomeFeedVC = [[PhotoFeedListKitViewController alloc] init];
UINavigationController *listKitHomeFeedNavCtrl = [[UINavigationController alloc] initWithRootViewController:listKitHomeFeedVC];
+ listKitHomeFeedNavCtrl.navigationBar.barStyle = UIBarStyleBlack;
listKitHomeFeedNavCtrl.tabBarItem = [[UITabBarItem alloc] initWithTitle:@"ListKit" image:[UIImage imageNamed:@"home"] tag:0];
listKitHomeFeedNavCtrl.hidesBarsOnSwipe = YES;
+
+
// UIKit Home Feed viewController & navController
PhotoFeedViewController *uikitHomeFeedVC = [[PhotoFeedViewController alloc] init];
UINavigationController *uikitHomeFeedNavCtrl = [[UINavigationController alloc] initWithRootViewController:uikitHomeFeedVC];
+ uikitHomeFeedNavCtrl.navigationBar.barStyle = UIBarStyleBlack;
uikitHomeFeedNavCtrl.tabBarItem = [[UITabBarItem alloc] initWithTitle:@"UIKit" image:[UIImage imageNamed:@"home"] tag:0];
uikitHomeFeedNavCtrl.hidesBarsOnSwipe = YES;
@@ -70,10 +75,6 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
[[UINavigationBar appearance] setBarTintColor:[UIColor darkBlueColor]];
[[UINavigationBar appearance] setTranslucent:NO];
- // iOS8 hides the status bar in landscape orientation, this forces the status bar hidden status to NO
- [application setStatusBarHidden:YES withAnimation:UIStatusBarAnimationNone];
- [application setStatusBarHidden:NO withAnimation:UIStatusBarAnimationNone];
-
#if WEAVER
WVDebugger *debugger = [WVDebugger defaultInstance];
[debugger enableLayoutElementDebuggingWithApplication:application];
diff --git a/examples/ASDKgram/Sample/Info.plist b/examples/ASDKgram/Sample/Info.plist
index 22adc008a..7641b2f1a 100644
--- a/examples/ASDKgram/Sample/Info.plist
+++ b/examples/ASDKgram/Sample/Info.plist
@@ -30,8 +30,6 @@
armv7
- UIStatusBarStyle
- UIStatusBarStyleLightContent
UISupportedInterfaceOrientations
UIInterfaceOrientationPortrait
@@ -46,6 +44,6 @@
UIInterfaceOrientationLandscapeRight
UIViewControllerBasedStatusBarAppearance
-
+
diff --git a/examples/ASDKgram/Sample/PhotoFeedBaseController.m b/examples/ASDKgram/Sample/PhotoFeedBaseController.m
index 473f2fc2e..d94a34e92 100644
--- a/examples/ASDKgram/Sample/PhotoFeedBaseController.m
+++ b/examples/ASDKgram/Sample/PhotoFeedBaseController.m
@@ -75,6 +75,11 @@ - (UIStatusBarStyle)preferredStatusBarStyle
return UIStatusBarStyleLightContent;
}
+- (BOOL)prefersStatusBarHidden
+{
+ return NO;
+}
+
- (CGSize)imageSizeForScreenWidth
{
CGRect screenRect = [[UIScreen mainScreen] bounds];
diff --git a/examples/ASDKgram/Sample/PhotoFeedListKitViewController.m b/examples/ASDKgram/Sample/PhotoFeedListKitViewController.m
index 950458e19..997e9451b 100644
--- a/examples/ASDKgram/Sample/PhotoFeedListKitViewController.m
+++ b/examples/ASDKgram/Sample/PhotoFeedListKitViewController.m
@@ -28,6 +28,8 @@ - (instancetype)init
UICollectionViewFlowLayout *layout = [[UICollectionViewFlowLayout alloc] init];
ASCollectionNode *node = [[ASCollectionNode alloc] initWithCollectionViewLayout:layout];
if (self = [super initWithNode:node]) {
+ self.navigationItem.title = @"ListKit";
+
CGRect screenRect = [[UIScreen mainScreen] bounds];
CGFloat screenScale = [[UIScreen mainScreen] scale];
CGSize screenWidthImageSize = CGSizeMake(screenRect.size.width * screenScale, screenRect.size.width * screenScale);
@@ -81,6 +83,16 @@ - (UIActivityIndicatorView *)spinner
return _spinner;
}
+- (UIStatusBarStyle)preferredStatusBarStyle
+{
+ return UIStatusBarStyleLightContent;
+}
+
+- (BOOL)prefersStatusBarHidden
+{
+ return NO;
+}
+
#pragma mark - IGListAdapterDataSource
- (NSArray> *)objectsForListAdapter:(IGListAdapter *)listAdapter