Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize code #25

Open
ThatXliner opened this issue Jul 31, 2021 · 0 comments
Open

Optimize code #25

ThatXliner opened this issue Jul 31, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@ThatXliner
Copy link
Owner

I've noticed that unmarkers.BaseUnmarker been documented as an "abstract base class" when we're actually using it otherwise.

Also, there's some dead code and we should actually sprinkle @staticmethod on some of them.

Here's my idea:

  • Move all the tag_* methods in BaseUnmarker ➡️ BasicUnmarker
  • Rename: BaseUnmarker ➡️ AbstractUnmarker
  • Alias: BaseUnmarker ➡️ BasicMarker
  • Run shed on the whole codebase (with --refactor)

Version bump: minor
@ThatXliner ThatXliner added the enhancement New feature or request label Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ThatXliner