Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search bar query #254

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Search bar query #254

merged 6 commits into from
Jan 16, 2024

Conversation

ESAM-ALSAWAH
Copy link
Contributor

@ESAM-ALSAWAH ESAM-ALSAWAH commented Aug 6, 2023 •
edited
Loading

Closes #253

Remove The results for search if the search input is empty

Before:

The.Algorithms.mp4

After:

The.Algorithms-fix.mp4

Checklist

  • I worked on a branch other than main.
  • My branch is up-to-date with the Upstream main branch.
  • I have fixed potential errors using yarn lint.
  • I ran yarn build to check everything still builds successfully.

@ESAM-ALSAWAH ESAM-ALSAWAH requested a review from maltejur as a code owner August 6, 2023 08:16
@vercel
Copy link

vercel bot commented Aug 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 3:53am

@ESAM-ALSAWAH ESAM-ALSAWAH mentioned this pull request Sep 2, 2023
Closed
maltejur
maltejur previously approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@maltejur maltejur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@maltejur maltejur enabled auto-merge September 6, 2023 16:15
auto-merge was automatically disabled September 12, 2023 05:51

Pull request was closed

@ESAM-ALSAWAH ESAM-ALSAWAH reopened this Sep 12, 2023
@Panquesito7 Panquesito7 added the bug Something isn't working label Jan 16, 2024
@Panquesito7 Panquesito7 added enhancement New feature or request and removed bug Something isn't working labels Jan 16, 2024
Panquesito7
Panquesito7 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@Panquesito7 Panquesito7 enabled auto-merge (squash) January 16, 2024 03:49
@Panquesito7 Panquesito7 merged commit 509429c into TheAlgorithms:main Jan 16, 2024
4 checks passed
@Panquesito7 Panquesito7 mentioned this pull request Jan 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@maltejur maltejur maltejur left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] The search bar shows results even if the input is empty.
3 participants
@ESAM-ALSAWAH @maltejur @Panquesito7