Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Inconsistency Check for incomplete Bucket assignments not working correctly #283

Closed
Lucaber opened this issue Jan 9, 2025 · 1 comment
Labels

Comments

@Lucaber
Copy link
Contributor

Lucaber commented Jan 9, 2025

Describe the bug
Transaction without a bucket assignment are no longer listed in the Transactions with incomplete bucket assignment check.
Since this commit we are only checking transactions with at least one assignment: 6ceab5d#diff-8c98081803abb074591e74499e634c35f890db48cf03211ebb17405c8495b245R137

To Reproduce

  • Create or import a new transaction without a bucket assignment.
  • View Data Inconsistency Page
@Lucaber Lucaber added the bug label Jan 9, 2025
@TheAxelander
Copy link
Owner

I see, after my refactoring the logic now only covers Transactions with at least 1 assignment but misses out the ones, which don't have any. I have added another query to make a check on that, too.

Thanks a lot for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants