Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hand does not shake w/Shaders #86

Open
Exokyhh opened this issue May 5, 2024 · 2 comments
Open

Hand does not shake w/Shaders #86

Exokyhh opened this issue May 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Exokyhh
Copy link

Exokyhh commented May 5, 2024

Describe the bug
When shaders are enabled, the hand does not shake when freezing.

To Reproduce
Steps to reproduce the behavior:

  1. Install and turn shaders on (I used complementary shaders)
  2. Go in a cold biome and start freezing
  3. When the player starts shaking, check your hand

Expected behavior
The player hand to shake, the same as when shaders are turned off

Game information (please complete)

  • MC Version: 1.20.1
  • Loader: Fabric 1.15.10

Logs
Not needed.

Additional context
None

@Exokyhh Exokyhh added the bug Something isn't working label May 5, 2024
@TheDeathlyCow
Copy link
Owner

Thanks for the report!

From my initial investigation, I can confirm that Iris does indeed seem to replace the item hand renderer with something of its own, causing Frostiful shaking to not appear to have an effect in game. The Fabric Rendering API does not seem to have a hand render event callback so I will probably have to homebrew a patch for this (or maybe I'll PR Fabric API with a new event).

@TheDeathlyCow
Copy link
Owner

TheDeathlyCow commented May 7, 2024

Personal notes for future me:

This is the conflicting mixin in iris: https://github.com/IrisShaders/Iris/blob/eb8042f780d6574731a53645665c5335a5e1c39f/src/main/java/net/irisshaders/iris/mixin/MixinGameRenderer.java#L451C1-L459C3

I don't see a way in the Iris API to re-add my hand callback.

Also tried using the WorldRenderEvents.END, but that didn't work (probably because the matrix stack is reset before the hand is rendered?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants