-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
per instance Scripty cache #1
Comments
is your new redis client connected to a different redis server? |
no the same server, but different object instance, I'm closing old instance and creating new one :) |
look at this example code: TheDeveloper/warlock#11 (comment) |
generally caching a user/client provided instance object (the redis client) is a bad idea along side |
oh yes I see, the redis client object is being cached along with the script. will merge your PR. |
thank you @TheDeveloper |
when can I switch to your npm? |
just published v0.0.5 :) warlock will pick up the latest version |
👍 |
using a global cache https://github.com/TheDeveloper/scripty/blob/master/lib/Scripty.js#L16 prevents from closing the redis client and create a new Scripty with a new redis client object.
The text was updated successfully, but these errors were encountered: