-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block/model spawning issues #267
Comments
Yes, the cauldron definitely has issues, I use BSS Cycles Edit for the cauldron instead. I tried UV mapping but got lost whoops. |
There are some major improvements needed for this operator. I was tempted to move the feature into an experimental flag, but since it's been out there long enough and enough people are using it, I'm going to keep it as is. Some extra try catching has been added, but major issues like UV issues still remain. I'm going to move this bug report into a later milestone, but noting a large number of reported bugs will now be resolved thanks to the extra try/catch and list check before referencing code added previously. I'm also hoping to add a way to capture what kinds of blocks people are attempting to generate to also get a sense where issues occur, possibly a mini survey asking if the block was generated correctly or not. I will not hold up releases on this however, and would prefer to hear from users on this thread (yes, anyone can reply!) with what they tried to spawn, attaching json files if appropriate (ie if not coming from the MCprep built in ones) |
Side note @StandingPadAnimations, idk if you have any interest in taking a crack at this or debugging some of the example failure cases here, I keep putting this off focussing on other items. No worries if not interested. |
Another object that can't load is the Held model of the Trident. (I was told to post these here in a support email) |
trident.txt Unfortunately all entities (mob/tile) they all hardcoded in Java in their model or renderer There are problems on how to handle store the hardcoded geometry and bring it in. or keep on using json ( in Block (model) spawner ) But there is a problem for the json method is how to handle variant special case like the bed or chest. Maybe some of the json model can point to the Entity Spawner to spawn it in or display a prompt for choosing the variants. |
Wanna add to "Blocks that spawn apparently without any geometry", Water also spawns with 8 unconnected vertices bunched up |
A note on the End Portal Frame: its geometry generates correctly, but the textures are mixed up. This can be fixed manually after spawning the block by simply reassigning the materials to the correct faces. This goes for both the End Portal Frame with and without an Eye of Ender inside of it. |
Since the PR for this was merged, the priority for this is lower now (although there are blocks that haven't added to that ignore list yet). |
With v3.3.0 just released, there are a few known issues already with the model spawner. Rather than wait until every single obscure block is functioning, the update instead comes a bit sooner but with some known issues. There may be more blocks than these that don't immediately work. There are likely more than the below, these are just the known ones so far
Blocks that spawn apparently without any geometry
Blocks that spawn with at least some geo, but have other artifacts:
Blocks that result in errors on spawn:
Materials could be auto-animated where relevant:
Because the generation is entirely procedural from json files, these may take some time to fix
The text was updated successfully, but these errors were encountered: