-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCprep 3.5 - Annotate and docummented util functions #418
MCprep 3.5 - Annotate and docummented util functions #418
Conversation
@StandingPadAnimations should be good with the anotations and f strings now. |
Thanks for working on these changes! Just an FYI that since your branch here is based on top of this PR #401, we'll want to merge that one first before we do this one. In the end, |
Will re-review once we have #401 merged into the |
Hey @StandingPadAnimations I noticed you closed this PR, was that intentional? Might need to re-open a new PR since I can't edit the base branch to be the milestone one. |
GitHub automatically closes PRs that refer to deleted branches, and recore was deleted after being merged |
As part of #401 add annotations to common functions
*edit: Also using f string
And #315 add a README docummented util.py