Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JPMS module descriptor #92

Closed
A248 opened this issue Jul 19, 2021 · 4 comments
Closed

Add JPMS module descriptor #92

A248 opened this issue Jul 19, 2021 · 4 comments

Comments

@A248
Copy link

A248 commented Jul 19, 2021

NightConfig does not include a module descriptor for use with JPMS. As such, dependents using the Java module system cannot rely on the unstable module name.

At the absolute minimum, NightConfig should declare an Automatic-Module-Name. Ideally, it should include a full module descriptor.

@TheElectronWill
Copy link
Owner

Hasn't this been solved by #84 ?

@A248
Copy link
Author

A248 commented Jul 20, 2021

My bad, I only noticed #50 but saw that it was closed.

If you don't mind my asking, do you intend to make a release in the near future which declares a stable module name?

I also noticed that #84 was merged to the stable-3.x branch and not the master branch. Is that relevant?

@TheElectronWill
Copy link
Owner

Yes, I should do a release soon (in a few days/weeks), which should include #84 :)

The master branch is the unstable next version of NightConfig, I will publish from the stable-3.x branch.

@A248
Copy link
Author

A248 commented Jul 20, 2021

Thanks, I appreciate your work. I've double-checked and the module names are valid (no dashes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants