Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SilentSoren; Endwalker Compendium - Final Version #2277

Merged

Conversation

SilverStrings5526
Copy link
Contributor

Silent Soren's FF compendium, backloaded to endwalker because my players are still using it and the new version breaks their sheets

Copy link
Owner

@TheGiddyLimit TheGiddyLimit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using the same source (FFXIV) as the other file won't work, you'll need to swap that out

there's also a length requirement now, so whatever you change it to needs to be >= 6 characters long

I'd recommend e.g. FFXIVBeforeTheFall

@SilverStrings5526
Copy link
Contributor Author

would i need to replace every instance of "FFXIV" or only when its preceded by "source"
image
image

@TheGiddyLimit
Copy link
Owner

every instance, I'm afraid

Copy link
Owner

@TheGiddyLimit TheGiddyLimit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File did not have ".json" extension: SilentSoren; Endwalker Compendium - Final Version

simple enough; file needs renamed to have .json on the end

Copy link
Owner

@TheGiddyLimit TheGiddyLimit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"json": "FFXIVBeforetheFallBeforetheFall",

looks like you've double-find-replace'd the json part on line 5, and it's breaking things

@TheGiddyLimit
Copy link
Owner

Copy link
Owner

@TheGiddyLimit TheGiddyLimit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid JSON now eh

https://jsonlint.com/

Copy link
Owner

@TheGiddyLimit TheGiddyLimit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as much as I enjoy being the go-between between the tests and this PR, you might consider running npm t locally until it passes

instructions should be available on the wiki, see e.g. "Testing your JSON"

@SilverStrings5526
Copy link
Contributor Author

hope this one works cause VSC shows all clear with the language server plugin

@TheGiddyLimit TheGiddyLimit merged commit cb6a17e into TheGiddyLimit:master Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants