-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create SilentSoren; Endwalker Compendium - Final Version #2277
Create SilentSoren; Endwalker Compendium - Final Version #2277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using the same source (FFXIV
) as the other file won't work, you'll need to swap that out
there's also a length requirement now, so whatever you change it to needs to be >= 6 characters long
I'd recommend e.g. FFXIVBeforeTheFall
every instance, I'm afraid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File did not have ".json" extension: SilentSoren; Endwalker Compendium - Final Version
simple enough; file needs renamed to have .json
on the end
…en; Endwalker Compendium - Final Version.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"json": "FFXIVBeforetheFallBeforetheFall",
looks like you've double-find-replace'd the json
part on line 5, and it's breaking things
needs e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invalid JSON now eh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as much as I enjoy being the go-between between the tests and this PR, you might consider running npm t
locally until it passes
instructions should be available on the wiki, see e.g. "Testing your JSON"
hope this one works cause VSC shows all clear with the language server plugin |
Silent Soren's FF compendium, backloaded to endwalker because my players are still using it and the new version breaks their sheets