Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add find_observables method #157

Closed
nadouani opened this issue Jun 3, 2020 · 2 comments · Fixed by #171
Closed

Add find_observables method #157

nadouani opened this issue Jun 3, 2020 · 2 comments · Fixed by #171
Assignees
Milestone

Comments

@nadouani
Copy link
Contributor

nadouani commented Jun 3, 2020

Request Type

Feature Request

Problem Description

Add a find_observable method to allow searching for observables, cross cases.

@nadouani nadouani added this to the 1.8.0 milestone Jun 3, 2020
@nadouani nadouani self-assigned this Jun 3, 2020
@dainok
Copy link

dainok commented Jun 26, 2020

I found that get_case_observables can be used, but it requires a case.

        # Append the custom query if specified
        if "query" in attributes:
            criteria = And(parent_criteria, attributes["query"])
        else:
            criteria = parent_criteria
        data = {
            "query": criteria
        }

Can we make case_id optional? Or should we implement a find_observables?

@nadouani
Copy link
Contributor Author

In general, I think that adding find_observables methods is needed, because it could be helpful in many use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants