Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing arbitrary props to NextTopLoader component #30

Closed
ProchaLu opened this issue Jul 24, 2023 · 0 comments · Fixed by #32
Closed

Allow passing arbitrary props to NextTopLoader component #30

ProchaLu opened this issue Jul 24, 2023 · 0 comments · Fixed by #32
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@ProchaLu
Copy link
Contributor

ProchaLu commented Jul 24, 2023

First of all, thank you for your amazing work on this library.

I have a suggestion that I believe would enhance the functionality of the NextTopLoader component. Currently, it provides several props for customization, which is great. However, I would like to propose adding a new feature that allows users to pass arbitrary props to the NextTopLoader component.

The inspiration for this feature comes from the template option in the nprogress package. With the ability to pass custom props, users like myself, for example, could add attributes such as data-test-id, which can significantly help in testing scenarios. Having the ability to set a data-test-id would allow us to easily check if the component has completed its loading process during testing.

I believe this addition would make the NextTopLoader even more versatile and further improve its usability. I hope this suggestion resonates with you.

Thank you once again for your hard work and consideration of this proposal.

@TheSGJ TheSGJ added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants