Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle notification (position, topOffset and width) in landscape mode #151

Merged
merged 7 commits into from
Jul 8, 2022
Merged

feat: handle notification (position, topOffset and width) in landscape mode #151

merged 7 commits into from
Jul 8, 2022

Conversation

mjaskowska
Copy link
Contributor

@mjaskowska mjaskowska commented Jul 5, 2022 •
edited
Loading

Update notifications in landscape mode.

  1. Handle topOffset depending on orientation
  2. Move default variants notifications to the right side when in landscape mode
  3. Change activationDistances in AndroidGestureConfig to hard-coded value

Simulator Screen Shot - iPhone 13 - 2022-07-07 at 15 32 53

@mjaskowska mjaskowska changed the title feat: add extraSpace to top offset only when isPortaitMode feat: handle notification in landscape mode Jul 5, 2022
@mjaskowska mjaskowska marked this pull request as draft July 5, 2022 15:22
@mjaskowska mjaskowska marked this pull request as ready for review July 6, 2022 08:00
danielmark0116
danielmark0116 suggested changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@danielmark0116 danielmark0116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. title (according to our sync :D)
  2. add some description to PR

LGTM 🔥

@mjaskowska mjaskowska changed the title feat: handle notification in landscape mode feat: handle notification (position, topOffset and width) in landscape mode Jul 7, 2022
@danielmark0116 danielmark0116 merged commit 885fdff into master Jul 8, 2022
@danielmark0116 danielmark0116 deleted the feat/top-offset-in-landscape branch July 8, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmark0116 danielmark0116 danielmark0116 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjaskowska @danielmark0116