Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init expo example app #155

Merged
merged 9 commits into from
Jul 26, 2022
Merged

feat: init expo example app #155

merged 9 commits into from
Jul 26, 2022

Conversation

mjaskowska
Copy link
Contributor

@mjaskowska mjaskowska commented Jul 9, 2022

Adds example-expo app.
Please note that react-native-notificated is installed to example-expo from current repo link and does not reflect all live changes introduced to the code the same way example does. If you wish to test your feature in example-expo during development, update path to react-native-notificated to match pattern: https://github.com/TheWidlarzGroup/react-native-notificated.git#your-branch-name in package.json

@mjaskowska mjaskowska marked this pull request as draft July 9, 2022 18:28
@mjaskowska mjaskowska marked this pull request as ready for review July 12, 2022 11:06
Copy link
Contributor

@danielmark0116 danielmark0116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, given that we have issues with realtiveDeps we can go with this imo. Check the example_docs tscofnig as we discussed

@mjaskowska mjaskowska merged commit 937dff6 into master Jul 26, 2022
@mjaskowska mjaskowska deleted the feat/example-expo-app branch July 26, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants