Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notification under modal #214

Merged
merged 14 commits into from
Jul 26, 2023
Merged

fix: notification under modal #214

merged 14 commits into from
Jul 26, 2023

Conversation

mateki0
Copy link
Contributor

@mateki0 mateki0 commented Jun 28, 2023

#211
I was trying to solve it globally but due to well-known issues with notification over modal in React-Native I wasn't able to do so.
One of potential solutions could be something similar to FullWindowOverlay from react-native-screens but we need both systems support without any additional dependencies.
This is probably a temporary solution until we or someone in the community finds a better solution.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2023

🚀 📲 Application preview:

Scan with your mobile:

Expo QR

or visit this link:

Published to https://exp.host/@thewidlarzgroup/notificated-example-expo?release-channel=155dfef3c17235a620341649ab8452571f8a182a

@mateki0 mateki0 marked this pull request as ready for review June 28, 2023 10:34
@mateki0 mateki0 self-assigned this Jun 29, 2023
@mateki0 mateki0 requested a review from woodrejs June 29, 2023 08:52
Copy link
Contributor

@woodrejs woodrejs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mateki0 mateki0 merged commit 77519d5 into master Jul 26, 2023
@mateki0 mateki0 deleted the fix/notification-under-modal branch July 26, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants