Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Update Exoplayer to 2.8.X #1166

Closed
Chubacca opened this issue Aug 3, 2018 · 3 comments
Closed

[Android] Update Exoplayer to 2.8.X #1166

Chubacca opened this issue Aug 3, 2018 · 3 comments

Comments

@Chubacca
Copy link

Chubacca commented Aug 3, 2018

Can we update Exoplayer to use 2.8.X? We currently have a hybrid native/react-native app and would like to use the newest Exoplayer, and the current react-native-video code is not compatible with 2.8.X.

Specifically 2.8.X removed the method "clearSelectionOverrides" in this commit. However, react-native-video calls the method here. There will potentially be other incompatibilities, but this was the exception we ran into first.

Platform

Which player are you experiencing the problem on:

  • Android ExoPlayer
@cobarx
Copy link
Contributor

cobarx commented Aug 4, 2018

I'll do this pretty soon and handle the API changes. There were some outstanding PRs I wanted to get merged first to avoid conflicts, but I think those are in now.

@cobarx
Copy link
Contributor

cobarx commented Aug 8, 2018

Done in #1170. I've handled all text track stuff. I didn't hit any issues with other features not working post upgrade, but testing would be welcome in advance of the release. You can grab the update off the master branch.

@cobarx cobarx closed this as completed Aug 8, 2018
@Chubacca
Copy link
Author

Did some minor testing off master and everything looks fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants