-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: True FullScreen mode for Android with ExoPlayer #1251
Comments
I'm not sure what we get by re-parenting the video. On iOS, that code is super buggy and doesn't work about half the time. Imo, it's a lot easier to work with to just set the video to have the same bounds as the device and call it a day. The biggest obstacle is that we don't have a set of controls with all the features you're mentioning. The ExoPlayer sample controls are super basic and don't look good imo. I have built several iterations of controls as React Native components that I will eventually be able to open source. I'd be curious of your thoughts on whether we should be aiming for native controls or a React Native component is sufficient. If we do the latter, should we also make them available on iOS? |
You might have a look at my repo. Because here, @IbrahimSulai is working on a build-in Fullscreen functionality, you can take my solution as temporary workaround |
Opened a PR (#1730) for full-screen support in Android Exoplayer. |
@ionut-movila I would just like to add the use of PlayerView, is how I was able to get video supported from android 4.4 and up in my native android application. If you guys added this feature, it would add 4.4 compatibility for sure. |
Hi @IbrahimSulai, |
Current behavior
The lib. does not support a full screen mode for Android at this moment. Only disabling status bar and buttons bar, with method ReactExoplayerView.setFullscreen but that is far from what a full functional full screen.
Expected behavior
Full screen mode should work in a similar way with what we have on iOS. The Video element should be re-parented to a new native view that will cover existing app content, like a full screen modal. This should also include all common controls: video scrubbing, volume controls, change aspect ratio + exit full screen.
This should work for Android ExoPlayer together with or without option
useTextureView
.A good starting point I have found is this answer https://stackoverflow.com/a/48511657.
I say approach no. 1 would work ok, even if it has some compromises for Android < 6 (API 23).
And also using SimpleExoPlayerView (or new PlayerView) for a full screen transition I guess is a good option.
Not to say that we really do need this feature in our app, but I would like to hear other opinions, and why not volunteers to implement it.
The text was updated successfully, but these errors were encountered: