Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable version value needs to use double quotes. Fails lint check. #2613

Closed
vincecoleman opened this issue Mar 8, 2022 · 3 comments
Closed

Variable version value needs to use double quotes. Fails lint check. #2613

vincecoleman opened this issue Mar 8, 2022 · 3 comments
Assignees
@freeboub
Labels
Platform: Android

Comments

@vincecoleman
Copy link

https://github.com/react-native-video/react-native-video/blob/63f12eaed666ebddf9a506889bf99232c2ea6c20/android-exoplayer/build.gradle#L48
@freeboub freeboub added Platform: Android triage needed Help needed to confirm the issue labels Jun 12, 2022
@hueniverse hueniverse removed the triage needed Help needed to confirm the issue label Jun 22, 2022
@jackyleehong
Copy link

Issue reproducible starting from v6.0.0-alpha.1 onwards

@freeboub freeboub reopened this Oct 15, 2022
@freeboub freeboub self-assigned this Oct 15, 2022
@freeboub freeboub mentioned this issue Oct 16, 2022
Merged
@freeboub
Copy link
Collaborator

Here is the patch ! https://github.com/react-native-video/react-native-video/pull/2891/files

@freeboub
Copy link
Collaborator

Fix will be available in 6.0.0.alpha.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@freeboub freeboub

Labels
Platform: Android
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hueniverse @jackyleehong @freeboub @vincecoleman