-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move startup props into a single configuration #2693
Comments
@freeboub and @armadilio3. Could you guys please come a list of props which is only for the player initialization? Any change to these props will be ignored after the initialization
|
I prefer breaking the people build in alpha after fixing this. I mean throw an exception when people still using original fullscreen and controls. Do you guys have any concerns? |
@wood1986 I already flag following props as 'startProps':
The good news is that we should be able to implement this change without changing external API. |
|
Done in: #4136 thank you @KrzysztofMoch |
Thank you for your feature request. We will review it and get back to you if we need more information. |
Thank you for your feature request. We will review it and get back to you if we need more information. |
1 similar comment
Thank you for your feature request. We will review it and get back to you if we need more information. |
reviewing the description of the ticket, and it seems that headers property implementation is missing: https://thewidlarzgroup.github.io/react-native-video/component/props#headers |
Thank you for your feature request. We will review it and get back to you if we need more information. |
Thank you for your feature request. We will review it and get back to you if we need more information. |
1 similar comment
Thank you for your feature request. We will review it and get back to you if we need more information. |
Thank you for your feature request. We will review it and get back to you if we need more information. |
1 similar comment
Thank you for your feature request. We will review it and get back to you if we need more information. |
Thank you for your feature request. We will review it and get back to you if we need more information. |
Thank you for your feature request. We will review it and get back to you if we need more information. |
Thank you for your feature request. We will review it and get back to you if we need more information. |
Feature Request
Create a new prop where all current props that are only used during initialisation and cannot be changed during runtime into a single configuration prop.
Why it is needed
This will make it more clear to developer as to which props can be changed during runtime and which props can only be provided when creating the player. This will also simplify the initialisation logic to get rid of
postDelayed
calls etc.Tasks
The text was updated successfully, but these errors were encountered: