Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move startup props into a single configuration #2693

Open
4 tasks done
armands-malejevs opened this issue May 25, 2022 · 14 comments · Fixed by #3835 · May be fixed by #4220
Open
4 tasks done

Move startup props into a single configuration #2693

armands-malejevs opened this issue May 25, 2022 · 14 comments · Fixed by #3835 · May be fixed by #4220
Assignees
Labels
7.0 Accepted Issue is confirmed and accepted by maintainers team feature help wanted The issue has been reviewed and is valid, and is waiting for someone to work on it.

Comments

@armands-malejevs
Copy link
Collaborator

armands-malejevs commented May 25, 2022

Feature Request

Create a new prop where all current props that are only used during initialisation and cannot be changed during runtime into a single configuration prop.

Why it is needed

This will make it more clear to developer as to which props can be changed during runtime and which props can only be provided when creating the player. This will also simplify the initialisation logic to get rid of postDelayed calls etc.

Tasks

  • textTracks (external subtitle tracks)
  • contentStartTime
  • drm
  • Ads props
@hueniverse hueniverse added feature help wanted The issue has been reviewed and is valid, and is waiting for someone to work on it. labels May 25, 2022
@freeboub freeboub self-assigned this Aug 1, 2022
@wood1986
Copy link
Contributor

@freeboub and @armadilio3. Could you guys please come a list of props which is only for the player initialization? Any change to these props will be ignored after the initialization

fullscreen
controls

@wood1986
Copy link
Contributor

wood1986 commented Oct 24, 2022

I prefer breaking the people build in alpha after fixing this. I mean throw an exception when people still using original fullscreen and controls. Do you guys have any concerns?

@freeboub
Copy link
Collaborator

freeboub commented Oct 25, 2022

@wood1986 I already flag following props as 'startProps':

  • textTracks (external subtitle tracks)
  • bufferConfig
  • contentStartTime
  • drm
  • header
  • useTunnelingPlayback (a change from my working branch I need to backport)

The good news is that we should be able to implement this change without changing external API.
in Video.js, we can get public input paramters and reformat then to provide it to native.
That's my plan, but I have a lack of time :)

@freeboub
Copy link
Collaborator

  • localSourceEncryptionKeyScheme for ios shall be moved to source.drm.localSourceEncryptionKeyScheme

@freeboub
Copy link
Collaborator

freeboub commented Sep 9, 2024

  • localSourceEncryptionKeyScheme for ios shall be moved to source.drm.localSourceEncryptionKeyScheme

Done in: #4136 thank you @KrzysztofMoch

Copy link

Thank you for your feature request. We will review it and get back to you if we need more information.

@freeboub freeboub added the Accepted Issue is confirmed and accepted by maintainers team label Sep 10, 2024
Copy link

Thank you for your feature request. We will review it and get back to you if we need more information.

1 similar comment
Copy link

Thank you for your feature request. We will review it and get back to you if we need more information.

@freeboub
Copy link
Collaborator

freeboub commented Sep 11, 2024

reviewing the description of the ticket, and it seems that headers property implementation is missing: https://thewidlarzgroup.github.io/react-native-video/component/props#headers
I cannot find implementation :/

Copy link

Thank you for your feature request. We will review it and get back to you if we need more information.

@freeboub freeboub linked a pull request Oct 5, 2024 that will close this issue
Copy link

github-actions bot commented Oct 5, 2024

Thank you for your feature request. We will review it and get back to you if we need more information.

1 similar comment
Copy link

github-actions bot commented Oct 5, 2024

Thank you for your feature request. We will review it and get back to you if we need more information.

@freeboub freeboub linked a pull request Oct 5, 2024 that will close this issue
Copy link

github-actions bot commented Oct 5, 2024

Thank you for your feature request. We will review it and get back to you if we need more information.

1 similar comment
Copy link

github-actions bot commented Oct 5, 2024

Thank you for your feature request. We will review it and get back to you if we need more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.0 Accepted Issue is confirmed and accepted by maintainers team feature help wanted The issue has been reviewed and is valid, and is waiting for someone to work on it.
Projects
None yet
4 participants