fix(avoid): avoid early return in setSrc #3759
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue found in sample
Use case:
Changes
Continue handling setSrc even is player is not allocated
Motivation
@KrzysztofMoch This is more a PR to discuss (even if it really fix the issue).
Don't you think this part of code should be called after reloadSource like in initializePlayerCode :
react-native-video/android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java
Line 628 in f87a793