Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): fix android source metadata compare #3775

Merged

Conversation

YangJonghun
Copy link
Collaborator

@YangJonghun YangJonghun commented May 15, 2024

Summary

fix internal android comparing code (compare source.metadata)

Motivation

Changes

  • "!=" always return true even if all data is the same, so I modified it to use implemented Object.equals fn.

Test plan

@YangJonghun
Copy link
Collaborator Author

fix #3763

@freeboub freeboub linked an issue May 16, 2024 that may be closed by this pull request
Copy link
Member

@KrzysztofMoch KrzysztofMoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrzysztofMoch KrzysztofMoch merged commit 6455380 into TheWidlarzGroup:master May 17, 2024
3 checks passed
@YangJonghun YangJonghun deleted the fix/android-metadata-compare branch May 18, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Android - media item cause blank video bug on edge case
3 participants