Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): resolve a release issue with DefaultDashChunkSource #4097

Merged
merged 1 commit into from
Aug 17, 2024
Merged

fix(android): resolve a release issue with DefaultDashChunkSource #4097

merged 1 commit into from
Aug 17, 2024

Conversation

seyedmostafahasani
Copy link
Collaborator

Summary

Motivation

Fix #4092.

Changes

Test plan

@seyedmostafahasani seyedmostafahasani mentioned this pull request Aug 17, 2024
Closed
@seyedmostafahasani
Copy link
Collaborator Author

seyedmostafahasani commented Aug 17, 2024 •
edited
Loading

@freeboub @KrzysztofMoch
If you have time, please release a new version with this change, as some users are unable to release a new version of their app with the latest version

@freeboub
Copy link
Collaborator

Yes I saw, I will check this afternoon, but I don't like this change it would be better to fix it on the gradle side, around the exclude call

@freeboub
Copy link
Collaborator

I cannot accomplish what I was expecting to do. let's merge this PR then.
The issue that exclude in the gradle file doesn't exclude .kt files. I tried to rework to use srcDirs instead of excludes, but unfortunnatlly, I cannot make it work as is...
Let's merge this PR as this is urgent. I will try to remove the stubs latter on.

@freeboub freeboub merged commit 7e222e8 into TheWidlarzGroup:master Aug 17, 2024
3 checks passed
@seyedmostafahasani
Copy link
Collaborator Author

@freeboub
Thank you 🙏.

@seyedmostafahasani seyedmostafahasani deleted the fix/release_issue branch August 17, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeboub freeboub freeboub approved these changes

@KrzysztofMoch KrzysztofMoch Awaiting requested review from KrzysztofMoch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Android: Type androidx.media3.exoplayer.dash.DefaultDashChunkSource$Factory is defined multiple times
2 participants
@seyedmostafahasani @freeboub