fix(JS): improve loader api #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o into chore/moveContentStartTimeIntoSource # Conflicts: # android/src/main/java/com/brentvatne/common/api/Source.kt
…o into fix/improveLoaderAPI # Conflicts: # examples/basic/src/VideoPlayer.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve renderLoader API
update api to allow function prop in renderLoader instead of Element.
Motivation
It is a performence motivation
With element, the element is created on every render.
With function, the element is rendered only when needed
Changes
Only JS changes
Test plan
Can be tested with the sample