Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poster prop needs to reflect Image 'source' prop #887

Closed
ptfly opened this issue Dec 29, 2017 · 0 comments
Closed

poster prop needs to reflect Image 'source' prop #887

ptfly opened this issue Dec 29, 2017 · 0 comments
Labels
stale Closed due to inactivity or lack or resources

Comments

@ptfly
Copy link

ptfly commented Dec 29, 2017

Currently the poster prop is a string which constructs Image's source.uri.
...<Image style={posterStyle} source={{uri: this.props.poster}}...

There are use cases where one might want to utilize all the source options currently available for the Image component, like custom headers for example. The PR #805 is also something that scratches the same context :)
@ptfly ptfly changed the title poster prop needs should reflect Image 'source' prop poster prop needs to reflect Image 'source' prop Dec 29, 2017
@hueniverse hueniverse added the stale Closed due to inactivity or lack or resources label Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale Closed due to inactivity or lack or resources
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hueniverse @ptfly