From 576273d712c2403bee7839e7ac806a85352693da Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Marin=CC=83o?= Date: Sat, 6 Jul 2019 13:58:18 +0200 Subject: [PATCH 1/2] fix when controls & muted --- ios/Video/RCTVideo.m | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ios/Video/RCTVideo.m b/ios/Video/RCTVideo.m index 71bf82d855..653d37051e 100644 --- a/ios/Video/RCTVideo.m +++ b/ios/Video/RCTVideo.m @@ -958,7 +958,9 @@ - (void)setMaxBitRate:(float) maxBitRate { - (void)applyModifiers { if (_muted) { - [_player setVolume:0]; + if (!_controls) { + [_player setVolume:0]; + } [_player setMuted:YES]; } else { [_player setVolume:_volume]; From 61a72ad0b0b4243b945ba52734dec5e1b8e38e8b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Marin=CC=83o?= Date: Sat, 6 Jul 2019 14:04:08 +0200 Subject: [PATCH 2/2] update changelog --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8668a91585..78749531d7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ ## Changelog +### next +* Fix mute/unmute when controls are present (iOS) [#1654](https://github.com/react-native-community/react-native-video/pull/1654) + ### Version 4.4.2 * Change compileOnly to implementation on gradle (for newer gradle versions and react-native 0.59 support) [#1592](https://github.com/react-native-community/react-native-video/pull/1592) * Replaced RCTBubblingEventBlock events by RCTDirectEventBlock to avoid event name collisions [#1625](https://github.com/react-native-community/react-native-video/pull/1625)