Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms 2.0.23 | Release date 30.08.2016 #252

Closed
ghost opened this issue Aug 26, 2016 · 6 comments
Closed

Forms 2.0.23 | Release date 30.08.2016 #252

ghost opened this issue Aug 26, 2016 · 6 comments

Comments

@ghost
Copy link

ghost commented Aug 26, 2016

Changelog

ThemeFuse/Unyson-Forms-Extension@v2.0.22...v2.0.23

Test

Download and extract in unyson/framework/extensions/forms

@ghost ghost closed this as completed Aug 30, 2016
@thednp
Copy link

thednp commented Oct 10, 2017

I would highly recommend breaking the form items into checkbox/view/view.php and checkbox/options.php.

OK I understand there are options that are required for the form to work, but for instance checkbox, you keep the core options and leave layout option into the options.php file along with other template related option like "Instructions for Users" and stuff.

@thednp
Copy link

thednp commented Oct 10, 2017

@ViorelEremia, @andreiglingeanu, @GheorgheP

What if I push a PR regarding these improvements?

@ViorelEremia
Copy link

I will merge your pr if everything is fine.

@thednp
Copy link

thednp commented Oct 11, 2017

@ViorelEremia, do you skype or something? Want to ask you some questions regarding the plans discussed here.

@thednp
Copy link

thednp commented Oct 11, 2017

@thednp
Copy link

thednp commented Oct 11, 2017

Deleted previous PRs and added a big one to include them all ThemeFuse/Unyson-Forms-Extension#52

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants