Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-image tag rendering attachment_id in src instead of URL if width and height is set #86

Open
pawitk opened this issue Nov 22, 2019 · 0 comments

Comments

@pawitk
Copy link

pawitk commented Nov 22, 2019

Hi,

I am currently building a wordpress site based off of the theme below:

I am facing the same issue as the posts below:
#23
ThemeFuse/Unyson#2871

tl;dr If width and height is set, it goes through fw_resize, which returns the attachment_id instead of image URL. This is then used as src for img tag, causing assets to not be loaded.

My questions are as follows:

  1. Did you manage to find a permanent solution for the issue threads above?

  2. I tried to edit the code in shortcodes/media-image/views/view.php by adding the temporary solution provided above in the above thread (Issue with image (Media element) #23), but results on the page does not reflect the changes in code. Is there any additional steps I have to take to get the code to be reloaded by Unyson?

  3. What is the best way to debug the plugin? I added logs to various places, but they don't seem to get called. I noticed the suggested method was to use fw_print(). Where do these logs get printed?

Thanks,

Pawit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant