Fix 110 add rscignore #1049
Closed
Fix 110 add rscignore #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add_rscignore_file() generates .rscignore at golem top level - call in add_rstudio_files() is used in RStudio connect, shiny server and shinyapps io - can be called directly Refs: ThinkR-open#110
ilyaZar
force-pushed
the
fix-110_add_rscignore
branch
3 times, most recently
from
377b9ab to
31b7567
Compare
- fix typos in two tests - update docs to pass CI - use different cat_green_tick() for app.R and .rscignore as they are called right after each other - move doc for rscignore down so man-page displays add_rstudioconnect_file at the top
ilyaZar
force-pushed
the
fix-110_add_rscignore
branch
from
31b7567 to
aa930b2
Compare
|
I'll test this in action on our Connect and let you know :) |
|
Cherry picked in https://github.com/ThinkR-open/golem/tree/1049-cherry-picked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #110
Done:
rsconnectversion0.8.25, or skip creation of file.here,CODE_OF_CONDUCT.md,vignettes,LICENSE.md,LICENCE.md.RbuildignoreNote keeping:
add_rscignore_file()add_rscignore_file()tests-add_deploy_helpers():add_rstudioconnect_file,add_shinyappsio_file,add_shinyserver_filehave a call toadd_rscignore_file()so their output is not properly tested anymore (they pass silently though).gitignoresyntax in.rcsignorerstudio/rsconnect#774.rscignore(e.g.add_entry_to_rscignore()).gitigoreand.Rbuildignorein.rscignorenot supported yetman/,dev/is not allowed atm. butman,devis possible, see above issue (one could take care of that in a separateadd_entry_to_rscignore()e.g.)