Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Arc around SyncWaker #538

Closed
Thomasdezeeuw opened this issue Mar 27, 2022 · 1 comment · Fixed by #577
Closed

Drop Arc around SyncWaker #538

Thomasdezeeuw opened this issue Mar 27, 2022 · 1 comment · Fixed by #577
Labels
performance Performance related issue. priority:low Low priority issue.

Comments

@Thomasdezeeuw
Copy link
Owner

Related code:

heph/src/actor/sync.rs

Line 145 in 09f5ff5

future_waker: Option<Arc<SyncWaker>>,

Because internally Thread already uses an Arc.
@Thomasdezeeuw Thomasdezeeuw added priority:low Low priority issue. performance Performance related issue. labels Mar 27, 2022
@Thomasdezeeuw
Copy link
Owner Author

We'll have to do some unsafe trickery, so not doing this now.

@Thomasdezeeuw Thomasdezeeuw mentioned this issue May 29, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Performance related issue. priority:low Low priority issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

io_uring support Thomasdezeeuw/heph
1 participant
@Thomasdezeeuw