This repository has been archived by the owner on Nov 11, 2024. It is now read-only.
fix: variable interpolation #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwiftWinds
changed the title
allow for variables to be interpolated mid-sentence fixes Thream#101
SwiftWinds
changed the title
theoludwig
suggested changes
Nov 18, 2021
There was a problem hiding this comment.
Thanks for your PR! @SwiftWinds
Could you add a test case, so we can avoid regression?
|
Sure! will do :) |
|
I added tests. Please let me know if they suffice :) |
|
🎉 This PR is included in version 4.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks for merging! happy to contribute :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101
I changed the regex to also allow for matching a whitespace. This guarantees that this matches cases where the variable is not interpolated as the last word in the line, but rather somewhere in the middle of the line, which was the edge case mentioned in #101 (and actually the same edge case as giuseppeg/styled-jsx-plugin-sass#32 (comment) from the original repo that this fork originated).