Skip to content
This repository has been archived by the owner on Nov 11, 2024. It is now read-only.

[Improvement] Deprecate usage of node-sass, instead only use of dart-sass #28

Closed
theoludwig opened this issue Apr 24, 2021 · 4 comments
Closed
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed improvement Improve structure/format/performance/refactor/tests of the code released
Milestone

Comments

@theoludwig
Copy link
Member

Proposal

We should only support dart-sass and not node-sass.

Quote from node-sass (see: https://www.npmjs.com/package/node-sass) :

Warning: LibSass and Node Sass are deprecated. While they will continue to receive maintenance releases indefinitely, there are no plans to add additional features or compatibility with any new CSS or Sass features. Projects that still use it should move onto Dart Sass.

@theoludwig theoludwig added good first issue Good for newcomers help wanted Extra attention is needed improvement Improve structure/format/performance/refactor/tests of the code labels Apr 24, 2021
@theoludwig theoludwig added this to the v4.0.0 milestone Apr 24, 2021
@bfanger
Copy link

bfanger commented Jul 14, 2021

The peerDependency on node-sass causes the npm install --save-dev @styled-jsx/plugin-sass to fail.
( MacOS 11 / node 16 / npm 7 )

Workaround:

npm install --save-dev --legacy-peer-deps  @styled-jsx/plugin-sass

@theoludwig theoludwig self-assigned this Jul 23, 2021
@theoludwig
Copy link
Member Author

Thanks for sharing the temporary workaround! @bfanger
I published 4.0.0, and this workaround is no longer necessary, as we're now using dart-sass.
Could you confirm that it actually works, with this new version ? 😄

@github-actions
Copy link

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bfanger
Copy link

bfanger commented Jul 23, 2021

@divlo 4.0.0 fixed the npm install issue 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers help wanted Extra attention is needed improvement Improve structure/format/performance/refactor/tests of the code released
Projects
None yet
Development

No branches or pull requests

2 participants