Adding Server-Generated Message ID To Received Message Attributes #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request resolves the issue I raised in #430 regarding missing server-generated message IDs in Watermill's Google Cloud Pub/Sub implementation. The change made is:
Server-Side Message ID Inclusion:
Modified the googlecloud package's default unmarshaller method to include Google's server-generated message IDs in message attributes, enabling users to access them.
A custom metadata key was created to avoid clash with existing implementations.
Test Coverage:
Added tests to ensure message IDs are present in received messages,
Expected Impact:
Improved compatibility with Google Cloud Pub/Sub.
Additional Notes:
Feedback is welcome for further refinement.