Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml does not declare all run-time dependencies #2031

Closed
selimnairb opened this issue Aug 2, 2024 · 1 comment
Closed

pyproject.toml does not declare all run-time dependencies #2031

selimnairb opened this issue Aug 2, 2024 · 1 comment

Comments

@selimnairb
Copy link

Using TileDB-Py 0.31.1, the packaging dependency is not declared in pyproject.toml, even though it appears to be needed:

<snip>
    return pd.DataFrame(A.df[:])
                        ^^^^
  File "libtiledb.pyx", line 1802, in tiledb.libtiledb.Array.df.__get__
  File "/Users/USER/venv/lib/python3.12/site-packages/tiledb/multirange_indexing.py", line 410, in __init__
    check_dataframe_deps()
  File "/Users/USER/venv/lib/python3.12/site-packages/tiledb/dataframe_.py", line 26, in check_dataframe_deps
    from packaging.version import Version
ModuleNotFoundError: No module named 'packaging'

The conda-forge feedstock does declare the packaging dependency.

My expectation is that pyproject.toml / installation instructions for TileDB-Py would declare all necessary run-time dependencies and that these would match those of the conda-forge feedstock, as I don't normally use conda (especially in containers), and it should not be required to use TileDB-Py.

@kounelisagis
Copy link
Member

kounelisagis commented Aug 5, 2024

Fixed by #2032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants